Skip to content

fix(developer): map shift key nextlayer property when importing OSK#16110

Merged
mcdurdin merged 1 commit into
masterfrom
fix/developer/14227-map-shift-key-on-import
Jun 30, 2026
Merged

fix(developer): map shift key nextlayer property when importing OSK#16110
mcdurdin merged 1 commit into
masterfrom
fix/developer/14227-map-shift-key-on-import

Conversation

@mcdurdin

@mcdurdin mcdurdin commented Jun 22, 2026

Copy link
Copy Markdown
Member

This is a minimal patch to address the problem where the imported shift key has no 'nextlayer' property. The whole import could stand to be rewritten in Typescript one day!

Fixes: #14227
Test-bot: skip

@keymanapp-test-bot

keymanapp-test-bot Bot commented Jun 22, 2026

Copy link
Copy Markdown

User Test Results

Test specification and instructions

User tests are not required

Test Artifacts

  • Developer
    • Keyman Developer - build : all tests passed (no artifacts on BuildLevel "build")
    • Compiler Regression Tests - build : all tests passed (no artifacts on BuildLevel "build")
    • Keyman Developer (old PRs) - build : all tests passed (no artifacts on BuildLevel "build")
    • kmcomp.zip - build : all tests passed (no artifacts on BuildLevel "build")
    • kmcomp.zip (old PRs) - build : all tests passed (no artifacts on BuildLevel "build")
  • Keyboards
    • Test Keyboards - build : all tests passed (no artifacts on BuildLevel "build")

@mcdurdin mcdurdin merged commit 36a437d into master Jun 30, 2026
10 checks passed
@mcdurdin mcdurdin deleted the fix/developer/14227-map-shift-key-on-import branch June 30, 2026 14:55
@github-project-automation github-project-automation Bot moved this from Todo to Done in Keyman Jun 30, 2026
@keyman-server

Copy link
Copy Markdown
Collaborator

Changes in this pull request will be available for download in Keyman version 19.0.249-alpha

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

bug(developer): Import touch layout does not select next layer appropriately on K_SHIFT key only

3 participants